Skip to content

Fix stopping of service #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2024
Merged

Fix stopping of service #146

merged 2 commits into from
May 25, 2024

Conversation

surajkumar
Copy link
Contributor

@surajkumar surajkumar commented May 25, 2024 •
edited
Loading

The stop functionality introduced in #115 did not work correctly. During testing:

  • it was not killing the gateway, the bot was still receiving and handling events
  • the executor was failing to shutdown and there were loads of threads still running in the background
  • the retry logic we have was re-initalizing the connection when the socket was disconnected

This PR implements the stop functionality properly and ensures all threads that were created have been killed.

@surajkumar surajkumar requested a review from a team May 25, 2024 11:38
@surajkumar
Copy link
Contributor Author

cc @mennafabio - you might find this interesting.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

notyourhabibti
notyourhabibti approved these changes May 25, 2024
View reviewed changes
Copy link

@notyourhabibti notyourhabibti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@surajkumar surajkumar merged commit adfd89b into main May 25, 2024
5 checks passed
@surajkumar surajkumar deleted the fix-stop branch May 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notyourhabibti notyourhabibti notyourhabibti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajkumar @notyourhabibti