Added some logging and slight refactoring to the request sender #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkumar
force-pushed
the
add-some-logging
branch
from
bee6b02 to
b9cfb78
Compare
SquidXTV
requested changes
May 23, 2024
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestBuilder.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestBuilder.java
Show resolved
Hide resolved
|
Taz03
requested changes
May 24, 2024
Comment on lines
+137
to
+140
| String headersString = | ||
| headers.entrySet().stream() | ||
| .map(entry -> entry.getKey() + "=" + entry.getValue()) | ||
| .collect(Collectors.joining(", ")); |
There was a problem hiding this comment.
y not just use default Map#toString
|
Closed in favour of #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small debug and trace logging to the reques sending bits of our code.
We have a ticket to improve logging so this is a step in that direction.