-
Notifications
You must be signed in to change notification settings - Fork 7
feat: adding stop() method #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! I have a bad memory, can you remind me of your discord username? |
Sure! :-) discord name is: dexxtrr |
That's no problem, I thought you were in there so I was a bit confused. Thanks for the contribution, will get it reviewed very soon. |
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java
Outdated
Show resolved
Hide resolved
…p method for DiscordRequestDispatcher.java
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what about the ignored InterruptedException in the DiscordRequestDispatcher#run
method? Wouldnt they cause problems if the executor actually interrupts the thread?
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/javadiscord/jdi/internal/api/DiscordRequestDispatcher.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
error from my side, i forgot to add my new gpg key. therefore i opened a new PR #115 with my signed cherry-picked commits. |
Describe the PR
This feature resolves #98 by adding a stop method to interrupt and close all thread pools and connections sockets within 30 seconds timeframe.
Checklist