Skip to content

feat: adding stop() method #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

mennafabio
Copy link
Contributor

Describe the PR
This feature resolves #98 by adding a stop method to interrupt and close all thread pools and connections sockets within 30 seconds timeframe.

Checklist

  • This PR contains environment variables
  • Documentation has been updated
  • Tests have been added
  • This PR contains breaking changes

@surajkumar
Copy link
Contributor

Thanks for the PR! I have a bad memory, can you remind me of your discord username?

@mennafabio
Copy link
Contributor Author

Thanks for the PR! I have a bad memory, can you remind me of your discord username?

Sure! :-) discord name is: dexxtrr
But im not in any server, was that required for contribution?

@surajkumar
Copy link
Contributor

Thanks for the PR! I have a bad memory, can you remind me of your discord username?

Sure! :-) discord name is: dexxtrr But im not in any server, was that required for contribution?

That's no problem, I thought you were in there so I was a bit confused. Thanks for the contribution, will get it reviewed very soon.

@mennafabio mennafabio requested review from Taz03 and SquidXTV May 19, 2024 23:41
Copy link
Member

@SquidXTV SquidXTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what about the ignored InterruptedException in the DiscordRequestDispatcher#run method? Wouldnt they cause problems if the executor actually interrupts the thread?

@mennafabio mennafabio requested a review from surajkumar May 21, 2024 16:18
Copy link
Contributor

@surajkumar surajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mennafabio
Copy link
Contributor Author

error from my side, i forgot to add my new gpg key. therefore i opened a new PR #115 with my signed cherry-picked commits.
@surajkumar guess you can close this one since merge is blocked due to unsigned commits in this one

@surajkumar surajkumar closed this May 22, 2024
@mennafabio mennafabio deleted the feature/stopMethod branch May 24, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a stop() method to the Discord class
4 participants