Sonar

Author: surajkumar

core/src/main/java/com/javadiscord/jdi/core/GatewayEventListener.java

@@ -38,9 +38,9 @@ public GatewayEventListener(Discord discord) {
     }
 
     public static Guild getGuild(Discord discord, Object event) {
-        if (event instanceof GuildModel) {
+        if (event instanceof GuildModel guildModel) {
             return createGuildFromEvent(
-                discord, (GuildModel) event
+                discord, guildModel
             );
         } else {
             return createGuildFromEventObject(discord, event);

core/src/main/java/com/javadiscord/jdi/core/interaction/InteractionEventHandler.java

@@ -49,6 +49,11 @@ public void onInteractionCreate(Interaction interaction, Guild guild) {
 
             if (validateParameterCount(method, paramOrder)) {
                 invokeHandler(handler, method, paramOrder);
+            } else {
+                throw new RuntimeException(
+                    "Bound " + paramOrder.size() + " parameters but expected "
+                        + method.getParameterCount()
+                );
             }
 
         } catch (Exception e) {
@@ -76,13 +81,7 @@ private List<Object> getOrderOfParameters(Method method, Interaction interaction
     }
 
     private boolean validateParameterCount(Method method, List<Object> paramOrder) {
-        if (paramOrder.size() != method.getParameterCount()) {
-            throw new RuntimeException(
-                "Bound " + paramOrder.size() + " parameters but expected "
-                    + method.getParameterCount()
-            );
-        }
-        return true;
+        return paramOrder.size() == method.getParameterCount();
     }
 
     private void invokeHandler(

example/lj-discord-bot/src/main/java/com/javadiscord/bot/utils/Executor.java

@@ -8,6 +8,10 @@ public class Executor {
     private static final ScheduledExecutorService EXECUTOR_SERVICE =
         Executors.newScheduledThreadPool(Runtime.getRuntime().availableProcessors());
 
+    private Executor() {
+        throw new UnsupportedOperationException("Utility class");
+    }
+
     public static void execute(Runnable runnable) {
         EXECUTOR_SERVICE.submit(runnable);
     }

example/lj-discord-bot/src/main/java/com/javadiscord/bot/utils/jshell/JShellService.java

@@ -22,8 +22,6 @@ public class JShellService {
 
     private final Map<Long, List<String>> history = new HashMap<>();
 
-    public JShellService() {}
-
     public JShellResponse sendRequest(String code) {
         record Request(String code) {}
         try (HttpClient client = HttpClient.newHttpClient()) {

gateway/src/main/java/com/javadiscord/jdi/internal/gateway/handlers/events/codec/handlers/interaction/InteractionCreateHandler.java

@@ -8,5 +8,10 @@
 public class InteractionCreateHandler implements EventHandler<Interaction> {
 
     @Override
-    public void handle(Interaction event, ConnectionMediator connectionMediator, Cache cache) {}
+    public void handle(Interaction event, ConnectionMediator connectionMediator, Cache cache) {
+        /*
+         * Empty because we do not need to do anything with interaction events at the
+         * gateway level
+         */
+    }
 }