Sonar

Author: surajkumar

annotations/src/main/java/com/javadiscord/jdi/core/processor/validator/EventListenerValidator.java

@@ -416,10 +416,11 @@ private boolean validateMethodAnnotations(Method method) {
         for (Map.Entry<Class<? extends Annotation>, String[]> entry : EXPECTED_PARAM_TYPES_MAP
             .entrySet()) {
             Class<? extends Annotation> annotationClass = entry.getKey();
-            if (method.isAnnotationPresent(annotationClass)) {
-                if (!validateMethodParameters(method, entry.getValue())) {
-                    return false;
-                }
+            if (
+                method.isAnnotationPresent(annotationClass)
+                    && !validateMethodParameters(method, entry.getValue())
+            ) {
+                return false;
             }
         }
         return true;

api/src/main/java/com/javadiscord/jdi/core/api/builders/command/CallbackMessage.java

@@ -35,8 +35,6 @@ public class CallbackMessage {
     @JsonProperty("poll")
     private Poll poll;
 
-    public CallbackMessage() {}
-
     public boolean isTts() {
         return tts;
     }

api/src/main/java/com/javadiscord/jdi/internal/api/application_commands/CreateCommandRequest.java

@@ -4,6 +4,7 @@
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
+import java.util.concurrent.atomic.AtomicReference;
 
 import com.javadiscord.jdi.core.api.builders.command.CommandOption;
 import com.javadiscord.jdi.core.api.builders.command.CommandOptionType;
@@ -23,11 +24,12 @@ public record CreateCommandRequest(
     @Override
     public DiscordRequestBuilder create() {
 
-        String path = "/applications/%s/commands".formatted(applicationId);
+        AtomicReference<String> path =
+            new AtomicReference<>("/applications/%s/commands".formatted(applicationId));
 
-        if (global.isPresent() && global.get()) {
-            path = "/applications/%s/guilds/%s/commands".formatted(applicationId, guildId);
-        }
+        global.ifPresent(
+            val -> path.set("/applications/%s/guilds/%s/commands".formatted(applicationId, guildId))
+        );
 
         Map<String, Object> body = new HashMap<>();
         body.put("name", name);
@@ -41,6 +43,6 @@ public DiscordRequestBuilder create() {
         return new DiscordRequestBuilder()
             .post()
             .body(body)
-            .path(path);
+            .path(path.get());
     }
 }

core/src/main/java/com/javadiscord/jdi/core/Constants.java

@@ -23,4 +23,8 @@ public class Constants {
          \\___/|____/___|  Version 1.0
         """;
 
+    private Constants() {
+        throw new UnsupportedOperationException("Utility class");
+    }
+
 }

example/lj-discord-bot/src/main/java/com/javadiscord/bot/utils/CurseWords.java

@@ -5,15 +5,15 @@
 
 public class CurseWords {
     public static boolean containsCurseWord(String text) {
-        for (String s : curseWords) {
+        for (String s : CURSE_WORDS) {
             if (text.toLowerCase().contains(s.toLowerCase())) {
                 return true;
             }
         }
         return false;
     }
 
-    private static final List<String> curseWords =
+    private static final List<String> CURSE_WORDS =
         Arrays.asList(
             "fuck",
             "shit",