fix splithalf error when two variables #281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a split-half reliability calculation error that occurs when there are only two variables in the analysis. The primary issue was that rowSums() would drop dimensions when applied to single-column matrices, causing downstream errors.
- Adds
drop = FALSEparameter torowSums()calls to preserve matrix dimensions - Fixes conditional logic structure in the item-deleted split-half analysis section
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
4
to
+5
|
|
||
|
|
There was a problem hiding this comment.
[nitpick] The added blank line at line 5 appears unnecessary and doesn't improve code readability.
Suggested change
Comment on lines
+1197
to
1200
|
|
||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] The added blank lines around the closing brace appear unnecessary and don't improve code readability.
Suggested change
| } | |
| } |
juliuspfadt
force-pushed
the
fixSplithalf
branch
from
41fcf45 to
a0d739b
Compare
juliuspfadt
force-pushed
the
fixSplithalf
branch
from
a0d739b to
9007c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes jasp-stats/jasp-issues#3727
renames "Coefficient" alpha and omega to "Cronbach's" and "McDonald's" as per @EJWagenmakers request. Initially, I had named them "Coefficient" because it is the correct way. Since people cannot find the coefficients though and I dont feel as strongly anymore, this is what it is.
Also changing to "Reliability" from "Unidimensional Reliability" makes this easier to find. The helpfile still specifies that it should be used for unidimensional data.