Skip to content

Conversation

@koenderks
Copy link
Collaborator

@koenderks koenderks commented Nov 22, 2024

  • Options to adjust x-axis for ICC plots

@koenderks koenderks changed the title Updates Differential Item Functioning (DIF) Nov 23, 2024
@koenderks koenderks marked this pull request as ready for review November 23, 2024 00:32
@koenderks koenderks requested a review from vandenman November 23, 2024 00:32
@koenderks koenderks mentioned this pull request Nov 27, 2024
4 tasks
Copy link
Contributor

@vandenman vandenman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments below, still need to check this in jasp.

defaultValue: 1
min: 1
max: 99999999
defaultValue: Math.floor(Math.random() * 1000000) // Init with random integer in [1,...,999999]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this use the setSeed reuseable element?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can, but that does not allow initialisation with a known but random seed.

Comment on lines 988 to 989
fit <- mirt::multipleGroup(data = state[["items"]], model = 1, itemtype = options[["model"]], group = dataset[[options[["groupingVariable"]]]], SE = FALSE, verbose = FALSE, TOL = options[["emTolerance"]], technical = list(NCYCLES = options[["emIterations"]], set.seed = options[["seed"]]))
dif <- mirt::DIF(fit, which.par = parameters)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested this, but can it fail/ does it need a try-catch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@koenderks koenderks requested a review from vandenman January 20, 2025 13:24
@vandenman vandenman merged commit c419b2e into jasp-stats:master Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants