chore: use readstat library from conan #6063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ah very nice, ill check this out soon |
JorisGoosen
force-pushed
the
useConan
branch
from
0c03350 to
7847ed8
Compare
JorisGoosen
approved these changes
Nov 11, 2025
Contributor
Author
|
hi @JorisGoosen seems build failed on Linux |
shun2wang
commented
Nov 11, 2025
| ${LIBFREEXL_LIBRARIES} | ||
| $<$<NOT:$<BOOL:${LINUX}>>:freexl::freexl> | ||
| # ReadStat ----------------------------------- | ||
| ${LIBREADSTAT_LIBRARIES} |
Contributor
Author
There was a problem hiding this comment.
why you remove this. needed by Linux I think.
Contributor
|
Yes I removed one line too many, ive fixed it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use the readstat library from conan as I have submit this successfully into conan-center this week already.
I need help cleaning up the code on macOS then
Dependencies.cmakefile might no longer be needed.