Prevent empty style attributes on ul.selected > li and ul.options > li
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janosh hi! This PR is ready for review. |
janosh
approved these changes
May 15, 2025
janosh
changed the title
ul.selected > li and ul.options > li
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for the excellent UI component. It works perfectly for my use case.
Reason for this PR
When I added the
style-src-attr 'none'directive to the Content-Security-Policy response header, I noticed the component stopped functioning. This issue occurred because thestyle=" null"attribute was being added to thelioption element.Summary of changes
This fix ensures that an invalid value,
" null", is not assigned to thestyleattribute of the element whenliSelectedStyle, orliOptionStyle, or the{style: { option: string; selected: string }}object is not passed.Checklist
[x] Tests are included.