Adds jsonPath to error messages, so errors can be pinpointed. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jsonPath can be used to provide better error messages to users trying
to create valid jsonLogic expressions
Also:
Fixes some exception messages to use the right operator. ("none", "or").
Aligns behavior to reference implementation for sums of unparseable strings,
as well as for between comparisons of > and >=, and for comparison operators
with arrays of more than three values.
When presented with an array parameter, jsonlogic.com uses the first value for + and * expressions.
jamsesso
reviewed
Apr 10, 2025
src/main/java/io/github/jamsesso/jsonlogic/evaluator/expressions/LogicExpression.java
Outdated
Show resolved
Hide resolved
jamsesso
reviewed
Apr 10, 2025
src/test/java/io/github/jamsesso/jsonlogic/ParseErrorTests.java
Outdated
Show resolved
Hide resolved
Also fixes a bug in the jsonPath calculation for and/or.
magnarn
force-pushed
the
magnarn/json-path
branch
from
b78405f to
887f9a4
Compare
|
Can you bump the version to |
jamsesso
approved these changes
May 2, 2025
|
1.1.0 was published to maven central. Thanks for the contribution :) |
|
Sorry to bother you, but did you see the bugfix PR? |
|
Heads up, this was a backwards incompatible change and broke when we attempted to pull it in. open-feature/java-sdk-contrib#1373 |
|
Yes. JsonLogicException now requires a JsonPath to pinpoint where in the JSON object the error originates. |
|
In the future, it would be awesome if the major version was updated instead to indicate the backwards incompatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jsonPath can be used to provide better error messages to users trying
to create valid jsonLogic expressions
Also:
Fixes some exception messages to use the right operator. ("none", "or").
Aligns behavior to reference implementation for sums of unparseable strings,
as well as for between comparisons of > and >=, and for comparison operators
with arrays of more than three values.
Handles edge cases of + and * the way jsonlogic.com does