Skip to content

Fix issue where path components are discarded for custom URLs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

provencher
Copy link

Previously, with custom providers, like Fireworks, parts of the path were being discarded preceeding the v1 version tag.

As a result, this meant that many providers would result in 404 errors trying to make api calls.

This fix properly combines all path components when making a request.

@lzell
Copy link
Contributor

lzell commented Feb 22, 2025

FYI @jamesrochabrun uses 3 space indent in Xcode. Would make the change clear if indent level stayed the same

@provencher
Copy link
Author

Ah fair enough. I'm a 4 space kind of guy - 3 is madness.

Just wanted to share the fix for now.

@provencher
Copy link
Author

provencher commented Feb 22, 2025

Damn this change broke Azure... This URL building setup is insanely obtuse lol

@jamesrochabrun
Copy link
Owner

Thanks @lzell for the 👀

Damn this change broke Azure... This URL building setup is insanely obtuse lol

@provencher managing different providers (now are so many) may end in not the most cleanest code I agree lol, can you share with me how the request will look like, a curl will be sufficient to see what we can do here :)

Thanks for the PR!

@sindresorhus
Copy link
Contributor

@provencher Bump ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants