-
Notifications
You must be signed in to change notification settings - Fork 21
Feature #59 Get All Players #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Added handler function to retrieve all players. - Implemented service method to retrieve all players. - Implemented repository method to retrieve all players.
- Adjusted error handling in repository methods. - Corrected struct definitions and usage in repository and service layers.
- Adjusted `GetAllPlayers` handler to return `204 No Content` when no players are found.
- Added unit tests for the `GetAllPlayers` handler. - Created mock implementation for `PlayerRepository` to facilitate testing.
- Added unit tests for the `GetAllPlayers` handler. - Created mock implementation for `PlayerRepository` to facilitate testing.
- Added unit tests for the `GetAllPlayers` handler. - Created mock implementation for `PlayerRepository` to facilitate testing.
|
No hay ninguna issue creada para este flow, así que te creare una nueva issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buen código 👍, me parece excelente. Aunque la issue de este flow no estaba creada. puede servirnos mas tarde tener un GetAllPlayers.
Solo faltaría corregir el comentario para el go doc y añadir el comentario para la doc de swagger y listo.
|
Gracias por los comentarios @DarcoProgramador estoy en camino de subir de nivel con GO y me gustaría colaborar en la comunidad. Reviews ajustadas ok 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tienes que buildear de nuevo el mock ya que el linter y los test dan error ya que no existe la función GetAll en los mock de Players
|
ajustado el mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Una pregunta, este endpoint retorna toooodos los players en la base de datos, cierto? 🤔
📝 Description
This PR introduces the following changes:
Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist: