Skip to content

Fix player names with * suffix and utf-8 encoding issue for Windows machines
Compare
Choose a tag to compare
@jaebradley jaebradley released this 04 May 21:38
· 89 commits to v4 since this release
4.9.1
2ff7d6d
This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode.

Summary

The relevant changes to the API are around

  1. Fixing player names in season total tables
  • Basketball Reference started adding * to the end of player names. The related changes (#176) strip out these * values
  1. Fixing a utf-8 encoding issue for Windows machines (#173) where CSV and JSON files need to have their encoding argument specified as utf8 (#180)

There are also changes related to creating an HTTPService and ParserService but these should not have any implications on the behavior of the external API.

Assets 2
Loading