Skip to content

Fix: fix pglogrepl.SendStandbyCopyDone #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: fix pglogrepl.SendStandbyCopyDone #57

wants to merge 1 commit into from

Conversation

zzzzwc
Copy link

@zzzzwc zzzzwc commented Aug 3, 2023

Change the return value '*CopyDoneResult' to struct to avoid NPE when receive a DataRow message.

@zzzzwc
Fix: fix pglogrepl.SendStandbyCopyDone
864b4b5 
Change the return value '*CopyDoneResult' to struct to avoid NPE when receive a DataRow message.
@zzzzwc zzzzwc force-pushed the fix-SendStandbyCopyDone branch from b91f3c7 to 864b4b5 Compare August 3, 2023 08:55
@jackc
Copy link
Owner

jackc commented Aug 5, 2023

Would it be better to instantiate a CopyDoneResult internally to resolve the bug rather than change the signature of the function? In theory, that's a breaking change... though I suppose no one could be relying on it because the current code crashes... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzzzwc @jackc