Generate docker best practices xml prompt #349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bren <bren@juanantonio.info>
Co-authored-by: bren <bren@juanantonio.info>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Created comprehensive XML system prompt (130-java-docker-best-practices.xml) - Covers Docker best practices specific to Java 25 applications - Includes multi-stage builds, JVM optimization, security, and monitoring - Generated corresponding markdown file - Updated SystemPromptsInventory to include new prompt - Updated all project Java versions to Java 25 - Updated Dockerfiles to use Eclipse Temurin Java 25 images
- Moved 130-java-docker-best-practices.md to the correct .cursor/rules/ location - Now properly integrated with Cursor's rules system
Co-authored-by: bren <bren@juanantonio.info>
Based on review of other system prompt documents, implemented: - Expanded goal section with 10 detailed principles following established patterns - Added context section explaining modern Java containerization challenges - Enhanced constraints with BLOCKING conditions and critical safety measures - Improved example descriptions with CDATA blocks and detailed explanations - Fixed XML entity encoding issues (& -> &) for proper schema validation - Updated markdown file in .cursor/rules/ directory - Restored Java 25 configuration across all projects The XML now follows the established PML schema patterns and provides more comprehensive guidance for Java 25 Docker containerization.
- Replaced JAVA_OPTS with JDK_JAVA_OPTIONS in all Docker examples - JDK_JAVA_OPTIONS is automatically applied to all Java processes - Provides better consistency and flexibility in containerized environments - Updated both Dockerfile and Kubernetes deployment examples - Added explanation in goal section about JDK_JAVA_OPTIONS benefits - Added safeguard recommendation to prefer JDK_JAVA_OPTIONS over JAVA_OPTS - Simplified ENTRYPOINT commands since JDK_JAVA_OPTIONS is automatic - Updated generated markdown file in .cursor/rules/ directory
Owner
Author
|
Not in this release. |
jabrena
deleted the
cursor/generate-docker-best-practices-xml-prompt-be9e
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR introduces a new XML system prompt detailing Docker best practices for Java 25 applications. Additionally, it updates all example projects to use Java 25, ensuring consistency and leveraging the latest Java features across the repository.
What changes are included in this PR?
130-java-docker-best-practices.xmltosystem-prompts-generator/src/main/resources, outlining Docker best practices for Java 25 applications (base images, multi-stage builds, JVM optimization, security, etc.).java.versionormaven.compiler.releaseto25in allpom.xmlfiles across example projects.examples/quarkus-demo/src/main/docker/Dockerfile.jvmandDockerfile.legacy-jarto useeclipse-temurin:25-jreas the base image.ENTRYPOINTcommands in the Quarkus Dockerfiles for compatibility with Eclipse Temurin.Are these changes tested?
The changes were applied programmatically by the AI assistant. No explicit tests were run by the assistant.
Are there any user-facing changes?