Use shutdown hook to write the remaining events #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisbsu
commented
Mar 10, 2022
| * We have been interrupted so write all of the rest of the events and then quit | ||
| */ | ||
|
|
||
| events.clear(); |
There was a problem hiding this comment.
Note: We shouldn't clear events because it can contain some messages which were not pushed into CloudWatch yet.
|
Thanks for this. I don't like making this a default. Making network connections while the JVM is shutting down seems like something the user can opt into. Maybe add a boolean to the configuration and default it to false? |
|
@j256 I have added a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use shutdown hook to write the remaining events to CloudWatch when JVM shuts down.