check domain configuration before starting Invidious #5352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
requested changes
Jun 21, 2025
| @@ -319,6 +319,18 @@ class Config | |||
| end | |||
| end | |||
|
|
|||
| # Check if the domain configuration is valid | |||
| if (domain = config.domain).nil? || domain.empty? | |||
| puts "Config: 'domain' is required/can't be empty" | |||
There was a problem hiding this comment.
domain can be empty on local instances.
Comment on lines
+327
to
+329
| if !parsed_domain.scheme.nil? | ||
| puts "Config: 'domain' cannot contain a scheme (#{parsed_domain.scheme})" | ||
| puts "Config: (Hint) Set 'domain' to '#{parsed_domain.host}'" |
There was a problem hiding this comment.
Even though the scheme is an usual mistake, we should probably catch all other kinds of errors (trailing /, port number, etc)...
Suggested change
| if !parsed_domain.scheme.nil? | |
| puts "Config: 'domain' cannot contain a scheme (#{parsed_domain.scheme})" | |
| puts "Config: (Hint) Set 'domain' to '#{parsed_domain.host}'" | |
| if domain != parsed_domain.domain | |
| puts "Config: 'domain' is invalid. | |
| if parsed_domain.host.presence | |
| puts "Config: (Hint) Did you mean #{parsed_domain.host} ?" | |
| else | |
| puts "Config: (Hint) 'domain' should look like this: invidious.example.com" | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5351