require base_job before the other jobs #5194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crystal compiler seems to evaluate `require` in an alphabetical way, so if anyone in the future, wants to add another job and that job is above `base_job.cr` in alphabetical order, the compiler is going to fail with `Error: undefined constant: Invidious::Jobs::BaseJob`. This doesn't fix anything, but it will prevent a future headache.
syeopite
approved these changes
Mar 1, 2025
unixfox
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crystal compiler seems to evaluate
requirein an alphabetical way, so if anyone in the future, wants to add another job and that job is abovebase_job.crin alphabetical order, the compiler is going to fail withError: undefined constant: Invidious::Jobs::BaseJob.This doesn't fix anything, but it will prevent a future headache.