4268: API Platform v4 #18
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
2 times, most recently
from
c146d38 to
903b9f9
Compare
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
7 times, most recently
from
1c220e6 to
daab726
Compare
# This is the 1st commit message: 4268: Added API tests # The commit message #2 will be skipped: # 4268: Added API tests
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
from
daab726 to
97ee09e
Compare
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
from
97ee09e to
c09b61c
Compare
turegjorup
reviewed
Jun 4, 2025
| @@ -1,18 +1,27 @@ | |||
| { | |||
| "api-platform/core": { | |||
| "version": "3.2", | |||
| "version": "4.1", | |||
There was a problem hiding this comment.
This doesn't match composer.json
There was a problem hiding this comment.
That sure looks weird … cleaned up in 56c129f.
.github/workflows/pr.yaml
Outdated
|
|
||
| psalm: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: ['8.3'] | ||
| php: ["8.3"] |
There was a problem hiding this comment.
Would be better if migrate ALL jobs/steps to run in docker
.github/workflows/pr.yaml
Outdated
| apispec: | ||
| runs-on: ubuntu-latest | ||
| name: API Specification validation | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php: [ '8.3' ] | ||
| php: ["8.3"] |
There was a problem hiding this comment.
Would be better if migrate ALL jobs/steps to run in docker
| - [PR-18](https://github.com/itk-dev/event-database-api/pull/18) | ||
| - Updated docker compose setup | ||
| - Added simple API tests and resolved some deprecations | ||
|
|
There was a problem hiding this comment.
Add note about updating API-Platform to 3.4?
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
2 times, most recently
from
15e7454 to
dddb92d
Compare
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
from
dddb92d to
f1675a7
Compare
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
from
cffbf37 to
a443e0f
Compare
rimi-itk
force-pushed
the
feature/4268-api-platform-v4
branch
from
a443e0f to
19278eb
Compare
Rome wasn't built in a day … 19278eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=4268#/tickets/showTicket/4268
Description
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.