exp: add --hide-workspace flag to exp show #10798
Conversation
MirjalilovS
force-pushed
the
feature/hide-workspace-10741
branch
from
1c62c2d to
d4e4ae9
Compare
|
Hi, I am failing a lot of CI checks and I am not sure how I can fix that. I followed the DVC Contributing Docs and managed to pass every test on my local machine. I have updated the relevant tests to account for the new feature. Any help would be greatly appreciated. Also, should documentation be created for this? I noticed whilst working on this issue that there are some exp show flags are not mentioned in the documentation such as --hide-queue and --hide-failed. This left me quite confused as to how I should proceed. Again, any help would be greatly appreciated. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10798 +/- ##
==========================================
+ Coverage 90.68% 91.06% +0.38%
==========================================
Files 504 504
Lines 39795 40283 +488
Branches 3141 3185 +44
==========================================
+ Hits 36087 36684 +597
+ Misses 3042 2969 -73
+ Partials 666 630 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was due to an upstream bug: jelmer/dulwich#1643, which is now been resolved.
Great finding. yes, this and all of those flags need to be documented. Looks like we forgot to update the docs when we introduced those flags in #8318. |
|
Thank you for your response. When making an issue for this in the docs repo, should it be separate for each feature or is it fine to put it all in one issue? |
It might be easier to create a PR directly than creating an issue. If you don't want to document other flags right now, it's okay to create just a single issue to track them. |
| @@ -319,4 +326,5 @@ def add_parser(experiments_subparsers, parent_parser): | |||
| action="store_true", | |||
| help="Force re-collection of experiments instead of loading from exp cache.", | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Unnecessary change.
MirjalilovS
force-pushed
the
feature/hide-workspace-10741
branch
from
d4e4ae9 to
1c62c2d
Compare
dvc/repo/experiments/collect.py
Outdated
| ExpState( | ||
| rev="workspace", | ||
| name=baseline_names.get("workspace"), | ||
| data=workspace_data.data, | ||
| error=workspace_data.error, | ||
| experiments=None, | ||
| ) |
There was a problem hiding this comment.
Why does this require creating ExpState again?
There was a problem hiding this comment.
Hi, thank you for flagging this. I have refactored those lines to something more elegant now
|
@MirjalilovS, would you be able to add a test for this? |
Adds a new --hide-workspace CLI flag to dvc exp show to allow hiding the workspace row from the output table. This helps users focus on committed baselines and experiments without including the current workspace state. Fixes iterative#10741.
Adds a new --hide-workspace CLI flag to dvc exp show to allow hiding the workspace row from the output table. Fixes iterative#10741.
skshetry
force-pushed
the
feature/hide-workspace-10741
branch
from
6726046 to
f0f8671
Compare
Hi, I added a test for the flag in tests/unit/command/test_experiments.py. I could not find any other tests for exp show flags so I assumed that was all that I had to do. Please let me know if there is anything else that needs to be added. |
Fixes #10741