Skip to content

Conversation

peppelinux
Copy link
Member

this PR resolves #852

@peppelinux peppelinux added this to the 1.2.1 milestone Oct 9, 2025
@peppelinux peppelinux requested a review from grausof October 9, 2025 08:51
@grausof grausof requested a review from Copilot October 15, 2025 10:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aligns onboarding sequence diagrams with their corresponding normative texts by simplifying the federation onboarding process flow and correcting terminology inconsistencies throughout the Italian and English documentation.

Key changes:

  • Simplified the federation onboarding sequence diagram by removing the /resolve endpoint interaction and streamlining the flow to focus on certificate issuance and subordinate statement fetching
  • Standardized terminology by consistently capitalizing "Credenziali" (Credentials) and "Attributi" (Attributes) throughout Italian documentation
  • Updated documentation version from 1.2.0 to 1.2.1

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/it/plantuml/federation-onboarding-process.puml Simplified federation onboarding flow by removing resolve endpoint steps and focusing on direct subordinate statement retrieval
docs/it/onboarding-high-level.rst Standardized capitalization of "Credenziali" and "Attributi" terms throughout the Italian documentation and updated PlantUML caption URLs
docs/it/conf.py Updated documentation version to 1.2.1
docs/en/plantuml/federation-onboarding-process.puml Applied same federation onboarding flow simplification as Italian version
docs/en/onboarding-high-level.rst Updated PlantUML caption URL to match new diagram
docs/en/conf.py Updated documentation version to 1.2.1
Comments suppressed due to low confidence (2)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -1,48 +1,36 @@
@startuml Federation Entity Onboarding Process
@startuml
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The diagram title has been removed. Consider adding a descriptive title back to the diagram for better documentation clarity, such as @startuml Federation Entity Onboarding Process.

Suggested change
@startuml
@startuml Federation Entity Onboarding Process

Copilot uses AI. Check for mistakes.

ta -> ta: Validate Entity Configuration at\n/.well-known/openid-federation endpoint
ta -> ta: Apply metadata policies with cascading effect
ta -> ta: Issue X.509 certificate for\nFederation Entity Public Key
ta -> ta: Issue X.509 Certificates about\nFederation Entity Public Keys in CSRs
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The preposition 'about' is awkward in this context. Consider using 'for' instead: 'Issue X.509 Certificates for Federation Entity Public Keys in CSRs' for better clarity.

Suggested change
ta -> ta: Issue X.509 Certificates about\nFederation Entity Public Keys in CSRs
ta -> ta: Issue X.509 Certificates for\nFederation Entity Public Keys in CSRs

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onboarding sequence diagrams are not aligned with the texts

1 participant