Skip to content

Conversation

steps88
Copy link
Collaborator

@steps88 steps88 commented Sep 30, 2025

Title

Content

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

steps88 and others added 4 commits October 6, 2025 10:10
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
@steps88 steps88 marked this pull request as ready for review October 8, 2025 14:57
@peppelinux peppelinux added this to the 1.2.1 milestone Oct 9, 2025
vs Pulsante d'Autenticazione e Pulsante di Ingaggio
and scan of QRcode from smartphone camera
alignment between ITA and ENG versione
@grausof grausof requested a review from Copilot October 15, 2025 10:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates terminology and specifications throughout the documentation, transitioning from Italian terms like "Sistema" and "Pulsanti di Ingaggio" to English-based terms like "Brand" and "Engagement Button". The PR also enhances the error handling specifications by adding new error types to the errors section as referenced in issue #729.

Key Changes:

  • Replaced Italian terminology with standardized English terms (e.g., "Pulsante di Ingaggio" → "Engagement Button", "Pulsante di Autenticazione" → "Authentication Button")
  • Enhanced error specifications with additional error types for attestation issuance and management
  • Clarified distinction between "Sistema IT-Wallet" (formal contexts) and "IT-Wallet" (brand/communications)
  • Changed several interface requirements from "SHOULD" to "MUST" for consistency

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/it/functionalities.rst Updates Italian terminology to use English button names, adds selection page requirements, strengthens interface requirements from SHOULD to MUST, and removes redundant text in error section
docs/it/brand-identity.rst Clarifies naming conventions distinguishing formal "Sistema IT-Wallet" from brand name "IT-Wallet", updates references from "Sistema" to "Brand", and fixes typo
docs/en/functionalities.rst Adds selection page requirements for same-device flow, updates cross-device flow with camera option, corrects error table actor assignments, and adds new error types
docs/en/brand-identity.rst Updates naming section to clarify formal vs. brand usage and changes "IT-Wallet System" to "IT-Wallet Brand" in visual identity section

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@steps88 steps88 requested a review from peppelinux October 15, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants