-
Notifications
You must be signed in to change notification settings - Fork 34
Text FIX and additions on design section (see description) #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: versione-corrente
Are you sure you want to change the base?
Conversation
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
Co-authored-by: Giuseppe De Marco <gi.demarco@innovazione.gov.it>
vs Pulsante d'Autenticazione e Pulsante di Ingaggio
and scan of QRcode from smartphone camera
alignment between ITA and ENG versione
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates terminology and specifications throughout the documentation, transitioning from Italian terms like "Sistema" and "Pulsanti di Ingaggio" to English-based terms like "Brand" and "Engagement Button". The PR also enhances the error handling specifications by adding new error types to the errors section as referenced in issue #729.
Key Changes:
- Replaced Italian terminology with standardized English terms (e.g., "Pulsante di Ingaggio" → "Engagement Button", "Pulsante di Autenticazione" → "Authentication Button")
- Enhanced error specifications with additional error types for attestation issuance and management
- Clarified distinction between "Sistema IT-Wallet" (formal contexts) and "IT-Wallet" (brand/communications)
- Changed several interface requirements from "SHOULD" to "MUST" for consistency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
docs/it/functionalities.rst | Updates Italian terminology to use English button names, adds selection page requirements, strengthens interface requirements from SHOULD to MUST, and removes redundant text in error section |
docs/it/brand-identity.rst | Clarifies naming conventions distinguishing formal "Sistema IT-Wallet" from brand name "IT-Wallet", updates references from "Sistema" to "Brand", and fixes typo |
docs/en/functionalities.rst | Adds selection page requirements for same-device flow, updates cross-device flow with camera option, corrects error table actor assignments, and adds new error types |
docs/en/brand-identity.rst | Updates naming section to clarify formal vs. brand usage and changes "IT-Wallet System" to "IT-Wallet Brand" in visual identity section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Title
Content
Review