Skip to content

fix istio_build metric #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

fix istio_build metric #1532

merged 2 commits into from
Apr 18, 2025

Conversation

zirain
Copy link
Member

@zirain zirain commented Apr 18, 2025

@zirain zirain added cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch cherrypick/release-1.26 Set this label on a PR to auto-merge it to release-1.26 branch labels Apr 18, 2025
@zirain zirain requested a review from a team as a code owner April 18, 2025 06:59
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2025
ilrudie
ilrudie approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@ilrudie ilrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@istio-testing istio-testing merged commit 3470f4b into istio:master Apr 18, 2025
3 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #1534

@istio-testing istio-testing mentioned this pull request Apr 18, 2025
Merged
@zirain zirain deleted the fix-istio-build-metrics branch April 18, 2025 13:55
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #1535

@istio-testing istio-testing mentioned this pull request Apr 18, 2025
Merged
@zirain zirain mentioned this pull request May 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilrudie ilrudie ilrudie approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.25 Set this label on a PR to auto-merge it to the release-1.25 branch cherrypick/release-1.26 Set this label on a PR to auto-merge it to release-1.26 branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

istio_build metric doesn't have build tag value
3 participants
@zirain @istio-testing @ilrudie