[release-1.24] Better support for root certificates #1526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split the last element of the returned response from the CA. This allows support for multiple roots. Note this requires a change to Istio (which I am making) to rever the regression in 1.25.1 (istio/istio#55793). * Split root from chain in the config_dump. Without this, it is impossible to know if something is a root or intermediate.
istio-testing
added
the
release-notes-none
istio-testing
added
the
size/L
|
/test test |
|
Looks like this and the 1.25 ones will need manual cherrypicks. Will attempt to look at tomorrow unless someone else can. cc: @howardjohn |
|
@istio-testing: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
#1546 resolves this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1510