Skip to content

[fixes #56772] Fix WasmPlugin .spec.url validation #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DerekTBrown
Copy link

What does this PR do?

  • Per the Istio documentation, if the oci:// prefix is missing in .spec.url, it is assumed that the URL is a oci:// image reference1.
  • Things like foo.bar:5000/baz:latest are valid image references, but do not pass validation, because this treats foo.bar as the schema.
  • I added an extensive set of test cases, then modified the validation logic to support each.

Footnotes

  1. https://istio.io/latest/docs/reference/config/proxy_extensions/wasm-plugin/#WasmPlugin-url.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 26, 2025
@istio-policy-bot
Copy link

😊 Welcome @DerekTBrown! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Jun 26, 2025
@istio-testing
Copy link
Collaborator

Hi @DerekTBrown. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DerekTBrown DerekTBrown marked this pull request as ready for review June 26, 2025 17:17
@DerekTBrown DerekTBrown requested a review from a team as a code owner June 26, 2025 17:17
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 26, 2025
@DerekTBrown DerekTBrown requested a review from howardjohn June 26, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants