-
Notifications
You must be signed in to change notification settings - Fork 571
Migrate storage version of networking APIs to v1 #3498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Faseela K <faseela.k@est.tech>
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
😊 Welcome @kfaseela! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
@keithmattix : wondering why |
Signed-off-by: Faseela K <faseela.k@est.tech>
Hmm looks like this doesn't work the way I remember it working. Will take a look |
Ah, I remember now @kfaseela. We need to manually edit the versions that we need to make the storage version. So e.g. nothing under v1alpha3 should have storage version; remove that and manually add the comment to the v1 copies |
Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right; let's try and get this merged soon so automator will pull it into istio/istio and we can confirm that the tests work
@dhawton do we need to cherrypick the api so this is available for 1.26? |
Yes. We're outside of the window for merge so it'd need TOC approval if it were to be brought into 1.26. So if you/TOC desires it, then it will need the label to be in there. |
Polling @istio/technical-oversight-committee |
We're really close to 1.26 release and I'd prefer not to throw a wrench in it. Let's target 1.27 with this |
1.27 is fine! |
Fixes istio/istio#55302