Skip to content

Clarify NR.7 ("Don't make data members protected") #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CppCoreGuidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -7773,6 +7773,8 @@ This kind of "vector" isn't meant to be used as a base class at all.

### <a name="Rh-protected"></a>C.133: Avoid `protected` data

**Alternative formulation**: Make member data `public` or (preferably) `private`.

##### Reason

`protected` data is a source of complexity and errors.
Expand Down Expand Up @@ -20560,7 +20562,7 @@ Non-rule summary:
* [NR.4: Don't insist on placing each class definition in its own source file](#Rnr-lots-of-files)
* [NR.5: Don't use two-phase initialization](#Rnr-two-phase-init)
* [NR.6: Don't place all cleanup actions at the end of a function and `goto exit`](#Rnr-goto-exit)
* [NR.7: Don't make all data members `protected`](#Rnr-protected-data)
* [NR.7: Don't make data members `protected`](#Rnr-protected-data)
* ???

### <a name="Rnr-top"></a>NR.1: Don't insist that all declarations should be at the top of a function
Expand Down Expand Up @@ -20900,7 +20902,7 @@ and spot the bug.
* Use exceptions and [RAII](#Re-raii)
* for non-RAII resources, use [`finally`](#Re-finally).

### <a name="Rnr-protected-data"></a>NR.7: Don't make all data members `protected`
### <a name="Rnr-protected-data"></a>NR.7: Don't make data members `protected`

##### Reason

Expand All @@ -20914,7 +20916,7 @@ and spot the bug.

##### Alternative

* [Make member data `public` or (preferably) `private`](#Rh-protected)
* [Avoid `protected` data](#Rh-protected)


# <a name="S-references"></a>RF: References
Expand Down
Loading