Skip to content

feat: add on-cordova helper #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions addon/helpers/on-cordova.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import Helper from "@ember/component/helper";
import { inject as service } from "@ember/service";

export function callbackWrapper(event, callback, bubbles) {
if (event.cancelBubble !== true) {
let shouldBubble = callback(event);

if (shouldBubble === false || bubbles === false) {
event.cancelBubble = true;
}

return shouldBubble;
}
}

export default Helper.extend({
cordovaEvents: service("ember-cordova/events"),

doFn(event) {
return callbackWrapper(event, this.fn, this.bubbles);
},

compute([event, fn], { bubbles = true }) {
this.fn = fn;
this.event = event;
this.bubbles = bubbles;
//this.doFn = (event) => callbackWrapper(event, this.fn, this.bubbles);
this.cordovaEvents.on(event, this, "doFn");
},

willDestroy() {
if (this.fn && this.event) {
this.cordovaEvents.off(this.event, this, "doFn");
}
this._super(...arguments);
},
});
1 change: 1 addition & 0 deletions app/helpers/on-cordova.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default, onCordova } from 'ember-cordova-events/helpers/on-cordova';
14 changes: 14 additions & 0 deletions tests/dummy/app/components/on-cordova-component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import Component from "@ember/component";
import { inject as service } from "@ember/service";

export default Component.extend({
cordovaEvents: service("ember-cordova/events"),
bubbles: true,

actions: {
yell() {
//eslint-disable-next-line
console.log(this.name);
},
},
});
14 changes: 14 additions & 0 deletions tests/dummy/app/controllers/application.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import Controller from '@ember/controller';
import { inject as service } from '@ember/service';

export default Controller.extend({
cordovaEvents: service('ember-cordova/events'),

currentEvent: 'backbutton',

actions: {
emitEvent() {
this.cordovaEvents.trigger(this.currentEvent, {});
}
}
})
16 changes: 11 additions & 5 deletions tests/dummy/app/templates/application.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
{{!-- The following component displays Ember's default welcome message. --}}
{{welcome-page}}
{{!-- Feel free to remove this! --}}

{{outlet}}
{{input value=(mut (get this "currentEvent"))}}
<button {{action "emitEvent"}}>
Emit event
</button>
<div>
{{#on-cordova-component name="grandfather"}}
{{#on-cordova-component name="father"}}
{{#on-cordova-component name="child"}}{{/on-cordova-component}}
{{/on-cordova-component}}
{{/on-cordova-component}}
</div>
23 changes: 23 additions & 0 deletions tests/dummy/app/templates/components/on-cordova-component.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<ul>
<li>
{{this.name}}
<button {{action (mut this.bubbles) (if this.bubbles false true)}}>
Bubbles:
{{if this.bubbles "true" "false"}}
</button>
</li>
{{on-cordova "backbutton" (action "yell") bubbles=this.bubbles}}
{{#if this.child}}
{{on-cordova-component name=(concat this.name "'s child")}}
{{/if}}
<button {{action (mut this.child) (if this.child false true)}}>
{{#if this.child}}
- Remove child for {{this.name}}
{{else}}
+ Add child for {{this.name}}
{{/if}}
</button>
<br>
<br>
{{yield}}
</ul>