Refer to kernel laucnhing thread instead of assuming the main thread #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssuming it's always the main thread
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ianthomas23
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Thanks @dfalbel.
Looking to get this in the 7.0.2 release, hopefully early next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a patch to address the issue described in #1438 (comment)
With this, we no longer asssume that the IPykernel app starts from the main thread. Instead, we keep a reference to the launching thread and compare to it when appropriate.