- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 391
 
update tests for 3.14 #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tests for 3.14 #1453
Conversation
      
          
      
      
            minrk
  
      
      
      commented
        Oct 15, 2025 
      
    
  
- move qt matrix out of hatch to CI because qt6 doesn't work on 3.14 and hatch doesn't seem to be able to exclude matrix entries (and we don't use the hatch matrix for anything else)
 - skip 3.14t which needs a jupyter-core release (coming soon)
 - test less than all combinations of Python + qt
 - the subprocess output capture tests seem to not work on 3.14. I don't understand why because the same code definitely does work perfectly in a notebook. Maybe conflicting somehow with pytest's FD output capture. So those tests are now skipped, but it's the test that is broken, not the actual behavior.
 
into CI so we can skip 3.14 + qt6
manual tests work fine, something funky with pytest
| 
           note: this doesn't increase the size of the build matrix, it actually shrinks it. What it does is shift a dimension of the matrix (qt5 or qt6) up from hatch to github, so we can do things like skip qt6 on 3.14 (and skip some others because we don't need every qt on every version, as long as we have upper/lower bounds covered)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @minrk
| 
           Note to self (or someone else if they beat me to it): needs backport to 6.x branch  | 
    
| 
           @meeseeksdev please backport to 6.x  | 
    
| 
           Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions: 
 
 
 
 
 
 And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the  If these instructions are inaccurate, feel free to suggest an improvement.  | 
    
(cherry picked from commit 93f11db)
Co-authored-by: Min RK <benjaminrk@gmail.com>
| 
           Manually backported by #1460.  |