Skip to content

Conversation

@minrk
Copy link
Member

@minrk minrk commented Oct 15, 2025

  • move qt matrix out of hatch to CI because qt6 doesn't work on 3.14 and hatch doesn't seem to be able to exclude matrix entries (and we don't use the hatch matrix for anything else)
  • skip 3.14t which needs a jupyter-core release (coming soon)
  • test less than all combinations of Python + qt
  • the subprocess output capture tests seem to not work on 3.14. I don't understand why because the same code definitely does work perfectly in a notebook. Maybe conflicting somehow with pytest's FD output capture. So those tests are now skipped, but it's the test that is broken, not the actual behavior.

minrk added 3 commits October 14, 2025 20:45
into CI

so we can skip 3.14 + qt6
manual tests work fine, something funky with pytest
@minrk minrk marked this pull request as draft October 15, 2025 04:40
@minrk minrk marked this pull request as ready for review October 15, 2025 04:49
@minrk
Copy link
Member Author

minrk commented Oct 15, 2025

note: this doesn't increase the size of the build matrix, it actually shrinks it. What it does is shift a dimension of the matrix (qt5 or qt6) up from hatch to github, so we can do things like skip qt6 on 3.14 (and skip some others because we don't need every qt on every version, as long as we have upper/lower bounds covered)

Copy link
Collaborator

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minrk

@ianthomas23 ianthomas23 merged commit 93f11db into ipython:main Oct 15, 2025
44 of 45 checks passed
@ianthomas23
Copy link
Collaborator

Note to self (or someone else if they beat me to it): needs backport to 6.x branch

@ianthomas23
Copy link
Collaborator

@meeseeksdev please backport to 6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 20, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 6.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 93f11dbb02692a7922cb6fdb4ebadffdb8b691c0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1453: update tests for 3.14'
  1. Push to a named branch:
git push YOURFORK 6.x:auto-backport-of-pr-1453-on-6.x
  1. Create a PR against branch 6.x, I would have named this PR:

"Backport PR #1453 on branch 6.x (update tests for 3.14)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

ianthomas23 pushed a commit to ianthomas23/ipykernel that referenced this pull request Oct 20, 2025
ianthomas23 added a commit that referenced this pull request Oct 20, 2025
Co-authored-by: Min RK <benjaminrk@gmail.com>
@ianthomas23
Copy link
Collaborator

Manually backported by #1460.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants