Use asyncio.Lock around subshell message handling #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
asyncio_lock
branch
from
ff96a1d to
602b8a4
Compare
|
Rebased on top of #1431. |
ianthomas23
force-pushed
the
asyncio_lock
branch
from
602b8a4 to
4939eb5
Compare
ianthomas23
force-pushed
the
asyncio_lock
branch
from
4939eb5 to
14692ef
Compare
ianthomas23
force-pushed
the
asyncio_lock
branch
from
c0c0fd1 to
46a3b7a
Compare
ianthomas23
force-pushed
the
asyncio_lock
branch
from
6e5075d to
7ff187c
Compare
ianthomas23
force-pushed
the
asyncio_lock
branch
2 times, most recently
from
fd04983 to
880283d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
asyncio.Lockaround subshell message handling.This decreases the flakiness of some JupyterLab UI tests when run locally.