Skip to content

Fix for MSVC #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for MSVC #307

wants to merge 1 commit into from

Conversation

rustyx
Copy link

@rustyx rustyx commented Jun 25, 2018

The example doesn't compile in MSVC:

1>\crow\examples\example_vs.cpp(96): error C2838: 'POST': illegal qualified name in member declaration
1>\crow\examples\example_vs.cpp(96): error C2065: 'POST': undeclared identifier
1>\crow\examples\example_vs.cpp(125): error C2838: 'DEBUG': illegal qualified name in member declaration
1>\crow\examples\example_vs.cpp(125): error C2065: 'DEBUG': undeclared identifier

This PR fixes it.

@ioriha
Copy link

ioriha commented Jun 27, 2018

I encounter this bug today and solve this by your method. Good job!!!

thinking-tower added a commit to thinking-tower/crow that referenced this pull request May 23, 2021
@thinking-tower
Change HTTPMethod::HEAD to HTTPMethod::Head, HTTPMethod::GET to
3bd1956 
HTTPMethod::Get and HTTPMethod::OPTIONS to HTTPMethod::Options.

VS2019 error:
enum "crow::HTTPMethod" has no member "HEAD"
enum "crow::HTTPMethod" has no member "GET"
enum "crow::HTTPMethod" has no member "OPTIONS"

See ipkn/crow#307 for a similar issue.
GerHobbelt pushed a commit to GerHobbelt/crow that referenced this pull request Jan 16, 2022
@The-EDev
Merge pull request ipkn#307 from CrowCpp/concurrency_fix
d668fa1 
Fix inconsistencies in `concurrency`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rustyx @ioriha