fix: reuse helia logger instead of creating a new one #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/reuse-helia-logger
branch
from
a450de5 to
2a8c168
Compare
Helia makes a logger available for use so use it instead of creating another one. It prefixes log lines for us which makes component log names more intuitive.
achingbrain
force-pushed
the
fix/reuse-helia-logger
branch
from
2a8c168 to
6413e8f
Compare
SgtPooki
approved these changes
Apr 15, 2024
Comment on lines
+5
to
10
| * This healthcheck script is used to check if the server is running and healthy | ||
| */ | ||
| const rootReq = await fetch(`http://${HOST}:${RPC_PORT}/api/v0/http-gateway-healthcheck`, { method: 'GET' }) | ||
| const rootReq = await fetch(`http://${HOST}:${RPC_PORT}/api/v0/http-gateway-healthcheck`, { | ||
| method: 'GET' | ||
| }) | ||
| const status = rootReq.status |
There was a problem hiding this comment.
nit: are we getting any logging information now that we're removing the log here?
the prior log was probably too verbose (log every 12 seconds..) but I just want to make sure we can see some type of healthcheck item if we need to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helia makes a logger available for use so use it instead of creating another one. It prefixes log lines for us which makes component log names more intuitive.
Change checklist