Skip to content

Preparing a v2.0.2+incompatible pre-release to properly retract v2.0.1+incompatible #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Preparing a v2.0.2+incompatible pre-release to properly retract v2.0.1+incompatible #254

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ea237c
Preparing a v2.0.42 release to properly retract v2.0.1+incompatible
AnomalRoil May 6, 2024
40092c1
Patching go mod issues
AnomalRoil Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,5 @@ require (
retract v1.0.22 // old gx tag accidentally pushed as go tag

retract v2.0.1+incompatible // old gx tag

retract v2.0.2-retract // we need to use a newer version than v2.0.1 to retract v2.0.1+incompatible, but we can retract ourself directly once done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing with: go.mod:28: retract github.com/ipfs/go-ipfs-cmds: version "v2.0.2-retract" invalid: should be v0 or v1, not v2

It looks like this might be because we'd need to change the import path in this go mod file as well golang/go#35732 (comment). I haven't dealt with two many v2 modules like this before though so lmk if I'm missing something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: Does this need to merge into master or can this merge into a v2.0.2-retract-branch and be released from there?

Copy link
Contributor Author

@AnomalRoil AnomalRoil Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sadly has to stay in the go.mod for subsequent releases and cannot just be removed after tagging the higher v2.0.2-retract self-retracting pre-release, but not 100% sure.

Loading