test: range requests of deserialized files #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results against Kubo master: Summary
|
|
Results against Kubo latest: Summary
|
lidel
commented
Jun 9, 2024
lidel
force-pushed
the
feat/advanced-unixfs-range-requests
branch
3 times, most recently
from
41e2a08 to
b7a423f
Compare
lidel
force-pushed
the
feat/advanced-unixfs-range-requests
branch
from
b7a423f to
789cfac
Compare
2 tasks
makes test more representative of seeking inside of a partially available file
|
Results against Kubo fix/range-suffix: Summary
|
content-type is not hard requirement, and implementations may have easier or harder time with coming up with the right one. if the content type info is not part of DAG metadata, and needs to me sniffed (majority of content in 2025), then this internal sniffing may produce different results in different file x library permutations. in practice, it does not matter, browsers will stream videos just fine. lets focus on Content-Range and body being correct - if we need to test Content-Type, let's move it to a different test suite
lidel
force-pushed
the
feat/advanced-unixfs-range-requests
branch
from
f2719c6 to
ad744bc
Compare
lidel
changed the title
2 tasks
lidel
commented
May 28, 2025
ensure behavior described in ipfs/boxo#856 (comment) is covered by test
v0.8.0Changed |
|
Because this adds new tests that will start failing in Kubo until fix from ipfs/boxo#922 lands, I'm shipping this. as Let's continue in ipfs/boxo#922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP port of HTTP Range tests described in #154 (comment)
cannot detect content-type: failed to fetch all nodesreturned right now by boxo/gateway (or create better fixture that does not clash with content-type sniffing logic)Accept-Ranges: byteshint on non-range deserialized responseAims to close #154