IIP50 slash unqualified candidates #4678
Open
+341
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
force-pushed
the
slash_self_staking
branch
from
ab43c26 to
3794c6e
Compare
envestcc
reviewed
Jul 22, 2025
action/protocol/rewarding/reward.go
Outdated
Comment on lines
197
to
204
| filteredCandidates := make([]*state.Candidate, 0) | ||
| for _, candidate := range candidates { | ||
| if _, ok := exemptAddrs[candidate.Address]; ok { | ||
| continue | ||
| } | ||
| filteredCandidates = append(filteredCandidates, candidate) | ||
| } | ||
| candidates = filteredCandidates |
There was a problem hiding this comment.
does it also included in hard fork?
envestcc
reviewed
Jul 23, 2025
| return errors.Wrap(err, "failed to fetch bucket") | ||
| } | ||
| prevWeightedVotes := p.calculateVoteWeight(bucket, true) | ||
| bucket.StakedAmount.Sub(bucket.StakedAmount, amount) |
There was a problem hiding this comment.
need a negative check of the bucket amount for safety
envestcc
reviewed
Jul 23, 2025
action/protocol/rewarding/reward.go
Outdated
| } | ||
| candidates = filteredCandidates | ||
| // TODO: add hardfork | ||
| slashAmount, err := p.slashUqd(ctx, sm, candidates, a.blockReward, uqdMap) |
There was a problem hiding this comment.
transfer slash amount to rewarding pool, and new a TransactionLog for it
CoderZhi
force-pushed
the
slash_self_staking
branch
from
b26a0ee to
4d14ae8
Compare
CoderZhi
force-pushed
the
slash_self_staking
branch
3 times, most recently
from
0b45a05 to
155905c
Compare
CoderZhi
force-pushed
the
slash_self_staking
branch
from
155905c to
09c6ea3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slash in epoch reward grant action handling
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: