Skip to content

Pin iota dependency to v1.2.3 and gather resources for Notarization wasm bindings #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 30, 2025

Conversation

chrisgitiota
Copy link
Contributor

@chrisgitiota chrisgitiota commented Jun 26, 2025

⚠️
⚠️
⚠️
⚠️ Do not merge this PR until we have clarified the release strategy for product-core
⚠️
⚠️ This PR gathers resources for notarization_wasm and IOTA v1.2.3
⚠️

Description of change

The included changes are

This PR is expected to depricate PR #33

The PR includes:

  • Pin iota dependency version to v1.2.3
  • Upstream merge from IOTA repository for iota_interaction/src/sdk_types
  • bindings/wasm/iota_interaction_ts:
    • A new simple signer implemented in TS, useful for test purposes: import { Ed25519KeypairSigner } from "@iota/iota-interaction-ts/test_utils"
    • bindings/wasm/iota_interaction_ts/lib/transaction_internal.ts: Function applyWithEvents added to Transaction interface
    • Enhanced iota_interaction_ts::error::TsSdkError usage to facilitate using TsSdkError in wasm-binding crates of our products
  • iota_interaction/src/sdk_types:
    • iota_json_rpc_types/iota_transaction.rs: Reordering of existing sources to better match the original source file in the IOTA repository.
  • product_common/src/bindings:
    • new macros module, containing macros needed for wasm-binding crates of our products
    • WasmTransaction: Implementation for Transaction::apply_with_events()
    • New feature "binding-utils" for product_common, providing several useful functions to facilitate implementing was-bindgen glue code especially for Transaction trait implementations

Links to any relevant issues

Helps to fix Wasm Library implementation #39

Fixes Identity issue #1677 - Integrate latest iota client

Type of change

Enhancement (a non-breaking change which adds functionality) + a downward compatible source code enhancement

How the change has been tested

The changes have been tested with

# Conflicts:
#	product_common/Cargo.toml
…ion.rs + iota_transaction.rs to allow upstream merges
…-and-resources-for-wasm

# Conflicts:
#	iota_interaction/src/sdk_types/iota_json_rpc_types/iota_transaction.rs
…via product_common to facilitate usage in several Identity crates
…perty `applyWithEvents` in the bounded JsValue before calling it and will call method `apply` otherwise
…cros shall be exported from `product_common` now
… is used instead of `serde_wasm_bindgen::to_value`
@chrisgitiota chrisgitiota merged commit dfa9729 into main Jun 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Integrate latest iota client [Task]: Wasm Library implementation
1 participant