fix(starfish): Fix tests test_restart_authority_committee #7957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
10 tasks
polinikita
force-pushed
the
feat/starfish/fix_transaction_flow
branch
from
d01ea2b to
4e90783
Compare
polinikita
changed the title
polinikita
force-pushed
the
feat/starfish/fix_transaction_flow
branch
from
4e90783 to
244fe01
Compare
NaitsabesMue
approved these changes
Jul 24, 2025
polinikita
merged commit 10b1aeb
into
consensus/feat/starfish-consensus
35 of 37 checks passed
NaitsabesMue
pushed a commit
that referenced
this pull request
Jul 28, 2025
# Description of change We adapted the tests to the Starfish logic and significantly enhanced the tested scenario. Specifically, in the test `test_restart_authority_committee()` 4 validators start for some time and sequence some transactions. Then one validator restarts, while others advance the DAG and sequence new transactions. The restarted node should catch up, by making use of commit syncer and transaction syncer. ## Links to any relevant issues Fixes #7956 ## How the change has been tested - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We adapted the tests to the Starfish logic and significantly enhanced the tested scenario. Specifically, in the test
test_restart_authority_committee()4 validators start for some time and sequence some transactions. Then one validator restarts, while others advance the DAG and sequence new transactions. The restarted node should catch up, by making use of commit syncer and transaction syncer.Links to any relevant issues
Fixes #7956
How the change has been tested
Release Notes