-
Notifications
You must be signed in to change notification settings - Fork 47
feat(consensus): add authority index to traces #7949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): add authority index to traces #7949
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it going to be printed on all types of deployments? It's unnecessary when running a standalone node, so perhaps we could make it conditional only when running tests or iota start
command? Otherwise it's fine for now.
84b7a6c
to
e22beb4
Compare
nice catch, |
…starfish/7944-starfish-add-authority-index-to-traces
2cc5c6b
into
consensus/feat/starfish-consensus
# Description of change Adds `{authority:[n]}:` in front of logs for tests only, where `n` is the `AuhtorityIndex`. e.g: ```shell 2025-07-23T09:33:56.609802Z DEBUG {authority=[0]}: starfish_core::core: crates/starfish/core/src/core.rs:625: 0 transaction are consumed by a block ``` fixes #7944 Be sure to reference any related issues by adding `fixes #(issue)`. ## How the change has been tested - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes ### Release Notes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Description of change
Adds
{authority:[n]}:
in front of logs, wheren
is theAuhtorityIndex
.e.g:
fixes #7944
Be sure to reference any related issues by adding
fixes #(issue)
.How the change has been tested
Release Notes