fix(core): use gas_owner() instead of sender() for gas object creation #7945
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
muXxer
approved these changes
Jul 23, 2025
Thoralf-M
approved these changes
Jul 23, 2025
|
resolve_transaction_transfer_with_sponsor test fails |
jkrvivian
force-pushed
the
fix/use-gas_owner-to-gas-obj
branch
from
01537f7 to
ca58b8c
Compare
piotrm50
approved these changes
Jul 24, 2025
jkrvivian
force-pushed
the
fix/use-gas_owner-to-gas-obj
branch
from
ca58b8c to
c39a4b8
Compare
Thoralf-M
reviewed
Jul 24, 2025
… and dry_exec_transaction_impl
jkrvivian
force-pushed
the
fix/use-gas_owner-to-gas-obj
branch
from
c39a4b8 to
c463ff6
Compare
TheMrAI
reviewed
Jul 24, 2025
TheMrAI
approved these changes
Jul 24, 2025
Thoralf-M
approved these changes
Jul 24, 2025
muXxer
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Replace
transaction.sender()withtransaction.gas_owner()when creating mock gas objects indry_exec_transaction_impl()andsimulate_transaction_impl().This ensures that gas objects are properly owned by the gas sponsor in sponsored transactions, rather than the transaction sender.
Include the mock gas object in the transaction's gas payment for both
dry_exec_transaction_impl()andsimulate_transaction_impl(). Previously, it wasn't added, causing misalignment oftransaction.gas()incheck_objects().Links to any relevant issues
Fixes #7892
How the change has been tested