feat(iota-core): add unit tests for the gas price feedback mechanism #7906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
roman1e2f5p8s
changed the title
thibault-martinez
approved these changes
Jul 24, 2025
muXxer
approved these changes
Jul 24, 2025
| // one transaction cannot fit in a commit. | ||
| #[tokio::test] | ||
| #[should_panic] // because `max_execution_duration_per_commit` is set too low. | ||
| async fn max_execution_duration_per_commit_too_low_in_total_gas_budget_mode() { |
There was a problem hiding this comment.
This is a fair test case, but do we actually have any safe guards against a certain transaction having gas budget greater than max_execution_duration_per_commit? It seems possible that it could happen.
There was a problem hiding this comment.
Thanks for looking at the tests. No, it seems we do not have any safeguards against a certain transaction having gas budget greater than max_execution_duration_per_commit. Looking at the numbers in Sui for TotalGasBudgetWithCap mode, max_accumulated_txn_cost_per_object_in_mysticeti_commit was set 37_000_000, while max gas budget was 50K SUI, so seems it would be possible to send a transaction that would never fit. In IOTA, max gas budget is currently set to 50 IOTA, but we never has TotalGasBudget mode enabled. I think it would be just safer to return the maximum gas price there instead of panic, I will change that part. Thanks for spotting this.
There was a problem hiding this comment.
Nice catch, @cyberphysic4l! I changed the logic for txs with durations exceeding max_execution_duration_per_commit.
piotrm50
approved these changes
Jul 28, 2025
cyberphysic4l
approved these changes
Jul 28, 2025
roman1e2f5p8s
merged commit 402f3f2
into
protocol-research/feat/gas-price-feedback
36 of 39 checks passed
roman1e2f5p8s
deleted the
protocol-research/feat/add-gas-price-feedback-unit-tests
branch
roman1e2f5p8s
added a commit
that referenced
this pull request
Jul 28, 2025
…7906) - This PR adds unit tests to test the gas price feedback mechanism. The aim is to test all the components: the mechanism itself, calculations of suggested gas price and its propagation across multiple commits. - Instead of panic, the calculator will now suggest reference gas price (or max clearing gas price) if transaction duration exceeds `max_execution_duration_per_commit`. - Renamed `congested_objects_gas_price_feedback_mechanism` feature flag to `congestion_control_gas_price_feedback_mechanism`. ```console cargo simtest -p iota-core unit_tests gas_price_feedback_tests ``` - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
roman1e2f5p8s
added a commit
that referenced
this pull request
Jul 28, 2025
…7906) - This PR adds unit tests to test the gas price feedback mechanism. The aim is to test all the components: the mechanism itself, calculations of suggested gas price and its propagation across multiple commits. - Instead of panic, the calculator will now suggest reference gas price (or max clearing gas price) if transaction duration exceeds `max_execution_duration_per_commit`. - Renamed `congested_objects_gas_price_feedback_mechanism` feature flag to `congestion_control_gas_price_feedback_mechanism`. ```console cargo simtest -p iota-core unit_tests gas_price_feedback_tests ``` - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
roman1e2f5p8s
added a commit
that referenced
this pull request
Jul 28, 2025
…7906) - This PR adds unit tests to test the gas price feedback mechanism. The aim is to test all the components: the mechanism itself, calculations of suggested gas price and its propagation across multiple commits. - Instead of panic, the calculator will now suggest reference gas price (or max clearing gas price) if transaction duration exceeds `max_execution_duration_per_commit`. - Renamed `congested_objects_gas_price_feedback_mechanism` feature flag to `congestion_control_gas_price_feedback_mechanism`. ```console cargo simtest -p iota-core unit_tests gas_price_feedback_tests ``` - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: Signed-off-by: Roman Overko <roman.overko@iota.org>
roman1e2f5p8s
added a commit
that referenced
this pull request
Jul 28, 2025
…7906) - This PR adds unit tests to test the gas price feedback mechanism. The aim is to test all the components: the mechanism itself, calculations of suggested gas price and its propagation across multiple commits. - Instead of panic, the calculator will now suggest reference gas price (or max clearing gas price) if transaction duration exceeds `max_execution_duration_per_commit`. - Renamed `congested_objects_gas_price_feedback_mechanism` feature flag to `congestion_control_gas_price_feedback_mechanism`. ```console cargo simtest -p iota-core unit_tests gas_price_feedback_tests ``` - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: Signed-off-by: Roman Overko <roman.overko@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
max_execution_duration_per_commit.congested_objects_gas_price_feedback_mechanismfeature flag tocongestion_control_gas_price_feedback_mechanism.Links to any relevant issues
How the change has been tested
cargo simtest -p iota-core unit_tests gas_price_feedback_testsRelease Notes