Skip to content

Conversation

jkrvivian
Copy link
Contributor

Description of change

Merge an upstream fix: MystenLabs/sui@bf79606

Do not wait on notify_read_effects for transactions that may be reverted after the epoch ends.

Links to any relevant issues

#4674

Type of change

  • Bug fix

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian added the node Issues related to the Core Node team label Feb 3, 2025
@jkrvivian jkrvivian self-assigned this Feb 3, 2025
@jkrvivian jkrvivian requested review from a team as code owners February 3, 2025 08:48
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:02am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:02am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:02am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 10:02am

@jkrvivian jkrvivian force-pushed the node/dont-wait-notify_read_effects-after-epoch-ends branch from 9d1df82 to 18bc738 Compare February 3, 2025 08:59
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also a change in await_transaction_effects on upstream, which doesn't exist yet in our version. Is this important as well?

@jkrvivian
Copy link
Contributor Author

There was also a change in await_transaction_effects on upstream, which doesn't exist yet in our version. Is this important as well?

The await_transaction_effects function has been separated from handle_certificates. This change was introduced in a previous PR (MystenLabs/sui#19401, included from v1.35.1), which added TransactionV2 RPC handler related to Mysticeti fastpath. I believe the consensus team will decide whether to implement the TransactionV2 changes. However, in this PR, I only apply changes that are compatible with the current codebase. 😃

@muXxer muXxer merged commit 523aa64 into develop Feb 5, 2025
41 checks passed
@muXxer muXxer deleted the node/dont-wait-notify_read_effects-after-epoch-ends branch February 5, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cherrypick] Must not wait on notify_read_effects after epoch ends, o… · MystenLabs/sui@bf79606

5 participants