fix(node): Fix logic for end-of-epoch checkpoint when dkg has failed #4899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
jkrvivian
approved these changes
Jan 20, 2025
muXxer
approved these changes
Jan 20, 2025
| randomness_round, | ||
| )); | ||
| } | ||
| // Determine whether to write pending checkpoint for user tx with randomness. |
There was a problem hiding this comment.
upstream had a newline between the bracket and the comment. Why did you remove it?
There was a problem hiding this comment.
Added the newline back in a8a6d2a, thanks for pointing that out!
piotrm50
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
If DKG has failed, we might accidentally construct two end of epoch checkpoints, refer to [cherrypick] Fix logic for end-of-epoch checkpoint when dkg has failed (#19976)
Links to any relevant issues
fixes #4672
Type of change
How the change has been tested
Ran the local network with
RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucetChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.