-
Notifications
You must be signed in to change notification settings - Fork 95
Post-Quantum (PQ) and Post-Quantum/Traditional (PQ/T) hybrid signatures for VCs #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Post-Quantum (PQ) and Post-Quantum/Traditional (PQ/T) hybrid signatures for VCs #1625
Conversation
…wp implementation
…tPresentationValidationOptions
…ntial is supported during presentation
…ise handling in JwkStoragePQ implementation
Hey @AleCla97, sorry for the long silence. I finally have the time to get this PR a to a merge-able state. Would you guys give me access to your fork? That way I can directly push commits there to fix the merge conflicts and adapt you code to the latest version of the library |
yeah sure :) I have added you. Let me know if there are any problems! |
@AleCla97 we are ready to merge, but we have a bad news. We cannot merge this PR until all commits have been signed with either a gpg or ssh key that you add to github (see how my commits as well as @AlbertoSvg have a green "verified" badge next to them?). Would you please look into that? You'll have to set up commit signing and then rebase the branch by re-signing all commits you have authored |
@AleCla97 another thing, unfortunately for internal policy we'd have to add the IOTA Foundation name along side LINKS in all the license headers, even though we didn't really authored them. Are you guys fine with that? Basically the headers will have both IOTA and LINKS together. |
@AleCla97 we found a workaround to avoid you guys the hassle of rebasing all of this. We can disable that constraint for this PR and I'll squash-merge it so that the merge-commit will be signed by my key. Disregard the above comment. |
@UMR1352 Thank you! For us, there is no problem having both names on the license headers :) |
Description of change
Integration of Post-Quantum (PQ) and Post-Quantum/Traditional (PQ/T) hybrid signatures for VCs
draft
Other changes
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Change checklist
Add an
x
to the boxes that are relevant to your changes.