Skip to content

Conversation

@gfariasalves-ionos
Copy link
Contributor

@gfariasalves-ionos gfariasalves-ionos commented Aug 4, 2025

What is the purpose of this pull request/Why do we need it?

This PR updates whatever is possible to get rid of CVEs, while still not upgrading Cluster API (that'd be another PR/issue). It also removes the tools directory in favor of using the tools directive.

Issue #, if available:

Description of changes:

Special notes for your reviewer:

Checklist:

  • Documentation updated
  • Unit Tests added
  • E2E Tests added
  • Includes emojis

This comment was marked as outdated.

This comment was marked as outdated.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Copy link
Contributor

@jriedel-ionos jriedel-ionos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various dependencies and modernizes the toolchain management by removing the separate tools directory in favor of using Go's native tools directive (introduced in Go 1.24). Key changes include updating Go version to 1.24.5 and numerous dependency updates.

  • Updates Go version from 1.24.3 to 1.24.5
  • Removes the dedicated tools directory and moves to Go's native tools directive
  • Updates multiple dependencies to newer versions to address CVEs

Reviewed Changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/tools.go Removed tools package file in favor of tools directive
tools/go.mod Removed tools module file as tools are now managed natively
test/e2e/*.go Removed legacy build constraints in e2e test files
go.mod Updated Go version and dependencies, added tools directive
Makefile Updated to use go tool instead of running from tools module
.github/dependabot.yml Minor formatting improvement in comment
Comments suppressed due to low confidence (1)

go.mod:3

  • Go version 1.24.5 does not exist. The latest stable version is Go 1.23.x. Consider using a valid Go version like 1.23.5 or the latest 1.22.x series.
go 1.24.5

@gfariasalves-ionos gfariasalves-ionos merged commit 349f223 into main Aug 6, 2025
11 of 12 checks passed
@gfariasalves-ionos gfariasalves-ionos deleted the update-lots-of-dependencies branch August 6, 2025 11:46
@gfariasalves-ionos gfariasalves-ionos added this to the v0.6.2 milestone Aug 6, 2025
@gfariasalves-ionos gfariasalves-ionos added area/dependency Issues or PRs related to dependency changes area/security labels Aug 6, 2025
gfariasalves-ionos added a commit that referenced this pull request Aug 6, 2025
**What is the purpose of this pull request/Why do we need it?**

This PR updates whatever is possible to get rid of CVEs, while still not
upgrading Cluster API (that'd be another PR/issue). It also removes the
tools directory in favor of using the tools directive.

**Issue #, if available:**

**Description of changes:**

**Special notes for your reviewer:**

**Checklist:**
- [ ] Documentation updated
- [ ] Unit Tests added
- [ ] E2E Tests added
- [x] Includes
[emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
# Conflicts:
#	go.mod
#	go.sum
#	tools/go.mod
#	tools/go.sum
jriedel-ionos added a commit that referenced this pull request Aug 11, 2025
Cherry-pick of #300

Co-authored-by: Gustavo Alves <112630064+gfariasalves-ionos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes area/security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants