Skip to content

Conversation

@avorima
Copy link
Contributor

@avorima avorima commented Dec 5, 2024

What is the purpose of this pull request/Why do we need it?

Align with internal image scanner.

Issue #, if available:

Description of changes:

Special notes for your reviewer:

Checklist:

  • Documentation updated
  • Unit Tests added
  • E2E Tests added
  • Includes emojis

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

@avorima avorima marked this pull request as ready for review December 5, 2024 11:49
Copy link
Member

@mcbenjemaa mcbenjemaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

not so important. but can we add a comment to the PR, when there is HIGH,CRITICAL

@avorima avorima merged commit 8f9ffc6 into main Dec 5, 2024
10 of 11 checks passed
@avorima avorima deleted the use-trivy branch December 5, 2024 12:00
@jriedel-ionos jriedel-ionos added this to the v0.5.1 milestone Jan 15, 2025
jriedel-ionos pushed a commit that referenced this pull request Jan 15, 2025
**What is the purpose of this pull request/Why do we need it?**

Align with internal image scanner.

**Issue #, if available:**

**Description of changes:**

**Special notes for your reviewer:**

**Checklist:**
- [ ] Documentation updated
- [ ] Unit Tests added
- [ ] E2E Tests added
- [x] Includes
[emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
jriedel-ionos added a commit that referenced this pull request Jan 15, 2025
Cherry-pick of #238 for release v0.5.1

Co-authored-by: Mario Valderrama <15158349+avorima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants