Skip to content

Main #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2025
Merged

Main #1

merged 7 commits into from
Jun 27, 2025

Conversation

ioncakephper
Copy link
Owner

@ioncakephper ioncakephper commented Jun 27, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Description by Korbit AI

What change is being made?

Update the commitlint configuration by adding specific commit message rules, remove commitlint configuration from package.json, and add @commitlint/cli and @commitlint/config-conventional as devDependencies.

Why are these changes being made?

The commitlint rules have been enhanced to enforce that commit types and subjects are not empty, ensuring better commit message quality. Moving the rules to a separate commitlint.config.js file provides clearer configuration management. Adding the necessary commitlint packages as devDependencies ensures the configuration is properly supported.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Design Redundant type-empty rule ▹ view
Files scanned
File Path Reviewed
commitlint.config.js

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Owner Author

@ioncakephper ioncakephper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/korbit-generate-pr-description

@ioncakephper ioncakephper merged commit 8e945ea into main Jun 27, 2025
2 checks passed
@ioncakephper ioncakephper deleted the chore/add-release-ci branch June 27, 2025 09:08
@ioncakephper
Copy link
Owner Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant