-
Notifications
You must be signed in to change notification settings - Fork 2.6k
experiment(backend): autocast dtype in CustomLinear #7843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
psychedelicious
wants to merge
2
commits into
main
Choose a base branch
from
psyche/experiment/backend/autocast-dtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
invokeai/backend/model_manager/load/model_cache/torch_module_autocast/cast_to_dtype.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
from typing import TypeVar | ||
|
||
import torch | ||
|
||
T = TypeVar("T", torch.Tensor, None, torch.Tensor | None) | ||
|
||
|
||
def cast_to_dtype(t: T, to_dtype: torch.dtype) -> T: | ||
"""Helper function to cast an optional tensor to a target dtype.""" | ||
|
||
if t is None: | ||
# If the tensor is None, return it as is. | ||
return t | ||
|
||
if t.dtype != to_dtype: | ||
# The tensor is on the wrong device and we don't care about the dtype - or the dtype is already correct. | ||
return t.to(dtype=to_dtype) | ||
|
||
return t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import torch | ||
|
||
from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.cast_to_device import cast_to_device | ||
from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.cast_to_dtype import cast_to_dtype | ||
from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.custom_modules.custom_module_mixin import ( | ||
CustomModuleMixin, | ||
) | ||
|
@@ -73,6 +74,10 @@ def _autocast_forward_with_patches(self, input: torch.Tensor) -> torch.Tensor: | |
def _autocast_forward(self, input: torch.Tensor) -> torch.Tensor: | ||
weight = cast_to_device(self.weight, input.device) | ||
bias = cast_to_device(self.bias, input.device) | ||
|
||
weight = cast_to_dtype(weight, input.dtype) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably fine, but some models may act weirdly due to potential precision loss if we provide inputs with less precision than the model 🤔 In an ideal world I'd think we'd want to ensure the precision of the inputs are compatible with the model before calling it |
||
bias = cast_to_dtype(bias, input.dtype) | ||
|
||
return torch.nn.functional.linear(input, weight, bias) | ||
|
||
def forward(self, input: torch.Tensor) -> torch.Tensor: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.