Skip to content

Notification Improvements #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

SchrodingersGat
Copy link
Member

This PR makes some adjustments / improvements to the notifications system.

  • Allow disabling of notification system entirely
  • Allow (some) selection of which notifications get sent
  • Improved documentation
  • Fill last remaining "placeholder" panel in the UI

@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Jun 2, 2025
@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface labels Jun 2, 2025
Copy link

netlify bot commented Jun 2, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 61da687
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/683e8eb4864c99000875a11a
😎 Deploy Preview https://deploy-preview-9721--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (6d47a0d) to head (61da687).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/models.py 66.66% 1 Missing ⚠️
src/backend/InvenTree/common/notifications.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9721   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files        1230     1230           
  Lines       53960    53979   +19     
  Branches     2255     2255           
=======================================
+ Hits        46596    46616   +20     
+ Misses       6794     6793    -1     
  Partials      570      570           
Flag Coverage Δ
backend 88.31% <91.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

</ActionIcon>
</Tooltip>
</Indicator>
{globalSettings.isSet('NOTIFICATIONS_ENABLE') && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we notifying superusers about errors with this disabled?

@matmair
Copy link
Contributor

matmair commented Jun 2, 2025

This PR removes (indirectly) the option to notify superusers about errors that occurred.
The settings pane is missing user specific settings so not really solving the placeholder.

@SchrodingersGat
Copy link
Member Author

This PR removes (indirectly) the option to notify superusers about errors that occurred.

Good point. How should we handle this?

  1. "error" notifications are always sent, ignoring the "global notifications" rule
  2. Add a "error notifications" category, which can be turned on while all others are turned off
  3. Another approach?

@SchrodingersGat
Copy link
Member Author

The settings pane is missing user specific settings so not really solving the placeholder.

That's in the "User Settings" page already:

image

@matmair
Copy link
Contributor

matmair commented Jun 3, 2025

I would say option 1

I am not really grasping the value that this change intends to deliver as notifications can be granulated turned off already

@matmair
Copy link
Contributor

matmair commented Jun 4, 2025

Looking at this again - this panel is still missing
grafik

@SchrodingersGat
Copy link
Member Author

Looking at this again - this panel is still missing

Yes, this has never yet been implemented in the new user interface. I'll have to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants