-
-
Notifications
You must be signed in to change notification settings - Fork 971
Notification Improvements #9721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Notification Improvements #9721
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9721 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 1230 1230
Lines 53960 53979 +19
Branches 2255 2255
=======================================
+ Hits 46596 46616 +20
+ Misses 6794 6793 -1
Partials 570 570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
</ActionIcon> | ||
</Tooltip> | ||
</Indicator> | ||
{globalSettings.isSet('NOTIFICATIONS_ENABLE') && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are we notifying superusers about errors with this disabled?
This PR removes (indirectly) the option to notify superusers about errors that occurred. |
Good point. How should we handle this?
|
…nTree into notification-tweaks
I would say option 1 I am not really grasping the value that this change intends to deliver as notifications can be granulated turned off already |
…nTree into notification-tweaks
Yes, this has never yet been implemented in the new user interface. I'll have to look into that. |
This PR makes some adjustments / improvements to the notifications system.