Skip to content

feat(frontend): Add authentication debug window #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

matmair
Copy link
Contributor

@matmair matmair commented Feb 21, 2025

Follow up to #6293
Adds a debug window that shows past authentications (only for superusers)
grafik
And here after a mandatory re-auth to change or view security-relevant information
grafik

@matmair matmair added enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface labels Feb 21, 2025
@matmair matmair added this to the 1.0.0 milestone Feb 21, 2025
@matmair matmair self-assigned this Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit db6ce62
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6848c2f9080aad000889dac2
😎 Deploy Preview https://deploy-preview-9120--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 4 from production)
Accessibility: 81 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (99ec486) to head (21c8fa7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/nav/MainMenu.tsx 50.00% 10 Missing and 1 partial ⚠️
...Index/Settings/AccountSettings/SecurityContent.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9120      +/-   ##
==========================================
- Coverage   85.93%   84.62%   -1.32%     
==========================================
  Files        1219     1209      -10     
  Lines       53369    53227     -142     
  Branches     2304     2572     +268     
==========================================
- Hits        45864    45042     -822     
- Misses       6922     7573     +651     
- Partials      583      612      +29     
Flag Coverage Δ
web 69.49% <53.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair matmair marked this pull request as ready for review February 24, 2025 21:07
@matmair
Copy link
Contributor Author

matmair commented Mar 2, 2025

@SchrodingersGat ready for review and merge

@SchrodingersGat
Copy link
Member

  1. Is this showing auths for all users, or just the superuser?
  2. Can we move this to a separate table in the "admin" section? It feels a bit too prominent for a rarely used feature

@matmair
Copy link
Contributor Author

matmair commented Mar 3, 2025

  1. this is showing auth for the current session -> especially helpful to find out why one was requested to provide a password again
  2. I do not think this makes sense in the admin section; running as a superuser should be a very limited occurrence, having a visual reminder is a plus in my book

@matmair matmair marked this pull request as draft April 24, 2025 23:10
@matmair matmair marked this pull request as ready for review June 10, 2025 22:55
@matmair
Copy link
Contributor Author

matmair commented Jun 11, 2025

@SchrodingersGat ready for review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an suggested enhancement or new feature User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants